Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't process inline <style> elements as CSS modules #7921

Merged
merged 2 commits into from Apr 8, 2022

Conversation

devongovett
Copy link
Member

Like the title says...

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 7, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.20s +89.00ms
Cached 467.00ms -10.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 485.80kb +0.00b 4.69s -269.00ms 🚀
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 4.69s -269.00ms 🚀
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 4.69s -269.00ms 🚀
dist/NotFound.960ab92b.js 429.00b +0.00b 4.69s -269.00ms 🚀
dist/logo.c5bb83f1.png 246.00b +0.00b 4.64s -266.00ms 🚀

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.43s -162.00ms
Cached 267.00ms -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 39b330e into v2 Apr 8, 2022
@devongovett devongovett deleted the css-modules-inline branch April 8, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants