Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass targets for swc/helpers to Rust and only filter them for preset env #8020

Merged
merged 4 commits into from Apr 30, 2022
Merged

Pass targets for swc/helpers to Rust and only filter them for preset env #8020

merged 4 commits into from Apr 30, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Apr 28, 2022 •
edited

...so that the syntax feature checks still work correctly (we just want to prevent infinite recursion for preset-env)

Part of #6676 (not sure if we've caught everything now).

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 28, 2022 •
edited

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.59s -643.00ms 🚀
Cached 455.00ms +3.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 486.35kb +0.00b 5.52s -601.00ms 🚀
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 5.52s -600.00ms 🚀
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 5.52s -600.00ms 🚀
dist/NotFound.960ab92b.js 429.00b +0.00b 5.52s -600.00ms 🚀
dist/logo.c5bb83f1.png 246.00b +0.00b 5.48s -631.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 486.35kb +0.00b 5.65s -445.00ms 🚀
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 5.65s -445.00ms 🚀
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 5.65s -445.00ms 🚀
dist/NotFound.960ab92b.js 429.00b +0.00b 5.65s -445.00ms 🚀
dist/logo.c5bb83f1.png 246.00b +0.00b 5.61s -440.00ms 🚀

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.28s -90.00ms
Cached 329.00ms +52.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 27034ec into v2 Apr 30, 2022
@mischnic mischnic deleted the swc-helpers-arrow-export branch April 30, 2022 19:29
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge remote-tracking branch 'upstream/v2' into wbinnssmith/merge-v2-…
56c5965 
…2022-04-22

* upstream/v2:
  Register swc error handler (#8032)
  Correctly emit warnings for unnecessary PostCSS plugins in package.json (#8024)
  Pass targets for swc/helpers to Rust and only filter them for preset env (#8020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mischnic @parcel-benchmark @wbinnssmith