Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image transformer): Update supported formats #8028

Merged
merged 3 commits into from May 3, 2022

Conversation

Commandtechno
Copy link
Contributor

@Commandtechno Commandtechno commented Apr 29, 2022

Reference issue: #8021

↪️ Pull Request

These formats are shown as supported here:

In the docs they are also stated as supported, but are not registered in the default config: https://github.com/parcel-bundler/website/blob/v2/src/recipes/image.md?plain=1#L34

💻 Examples

These formats are silently not transformed (see original issue)

🚨 Test instructions

Similarly to #8018 I'm not sure if this needs tests, but if it does, please let me know and I can convert this to a draft. The image transformer doesn't seem to have tests currently.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • [ ✅ ] Included links to related issues/PRs

@mischnic mischnic merged commit 851480d into parcel-bundler:v2 May 3, 2022
@CWSites
Copy link

CWSites commented May 23, 2022

I see this was merged almost 3 weeks ago, when will it be released and/or how can I bring it into my project? I'm trying to use a .gif and it breaks my entire build doing so.

@devongovett
Copy link
Member

Release will be soon, but in the meantime you can always add a .parcelrc to your project:

{
  "extends": "@parcel/config-default",
  "transformers": {
    "*.gif": ["@parcel/transformer-image"]
  }
}

Check out the docs if you want to learn more about configuring parcel. https://parceljs.org/features/plugins/

@CWSites
Copy link

CWSites commented May 23, 2022

Thank you!

gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  fix: getNodeIdsConnected should remove duplicate values (#8054)
  chore: should log unsupported type not zero and toLocaleString's option typo (#8002)
  Allow animated images (#8018)
  Add "key" and "update_url" to webextension manifest schema (#8043)
  Allow to define the "compilerOptions" of the VueTransformer (#8031)
  fix(image transformer): Update supported formats (#8028)
  support for `oauth2` field in mv3 (#8037)
  Update @parcel/css to 1.8.2 (#8044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants