Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward useDefineForClassFields to swc #8107

Merged
merged 2 commits into from May 21, 2022
Merged

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented May 18, 2022

Fixes #8036

Also a non-breaking swc bump to fix swc-project/swc#4703

@parcel-benchmark
Copy link

parcel-benchmark commented May 18, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.32s -21.00ms
Cached 456.00ms -15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.66m -123.00ms
Cached 2.65s +29.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.34edd600.js 3.33mb +144.00b ⚠️ 32.50s +330.00ms
dist/16.069344b7.js 905.00b +0.00b 40.99s +4.42s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.24m +33.93s ⚠️
dist/index.html 240.00b +0.00b 35.80s +3.58s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.92s +23.00ms
Cached 277.00ms -16.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 9a44f02 into v2 May 21, 2022
@devongovett devongovett deleted the useDefineForClassFields branch May 21, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants