Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply unresolved mark to inserted undefined identifiers #8151

Merged
merged 4 commits into from May 27, 2022
Merged

Apply unresolved mark to inserted undefined identifiers #8151

merged 4 commits into from May 27, 2022

Conversation

mischnic
Copy link
Member

Fixes #8143

  • swc already has a type alias for (JsWord, SyntaxContext), so just use that instead of our own
  • Apply unresolved mark to inserted undefined identifiers. swc's DCE pass relies on this

@mischnic mischnic requested a review from devongovett May 27, 2022 09:45
@parcel-benchmark
Copy link

parcel-benchmark commented May 27, 2022 •
edited

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 12.45s -298.00ms
Cached 544.00ms -34.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.12m -4.81s
Cached 3.16s -54.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.3a01a3a0.js 1.27mb -1.18kb 🚀 1.59m -3.33s

Cached Bundles

Bundle Size Difference Time Difference
dist/index.3a01a3a0.js 1.27mb -1.18kb 🚀 1.60m -2.87s

Three.js ✅

Timings

Description Time Difference
Cold 8.59s -184.00ms
Cached 335.00ms -9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 9a5d48d into v2 May 27, 2022
@devongovett devongovett deleted the swc-cleanup branch May 27, 2022 14:15
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge remote-tracking branch 'upstream/v2' into atlassian
62f7f8b 
* upstream/v2:
  Normalize object literal shorthand even when wrapped (#8155)
  add invalidateOnEnvChange to resolver (#8103)
  Apply unresolved mark to inserted `undefined` identifiers (#8151)
@mischnic mischnic mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional require produces invalid output
3 participants
@mischnic @parcel-benchmark @devongovett