Cache invalidations for packagers when reading other bundles #8370

mischnic · 2022-08-05T15:51:57Z

~~loadGlobalInfo is probably not a good name~~ loadBundleConfig, same API as loadConfig (plus bundle and bundleGraph)

Test case

mischnic · 2022-08-05T15:54:25Z

packages/core/core/src/PackagerRunner.js

+      // TODO expose config and let plugin set key?
+      config.cacheKey = hashString(JSON.stringify(config.result) ?? '');


Should this new method also receive a config object (currently it doesn't)? Currently the cache key logic for the config is a bit counterintuitive, especially for this new usecase:

parcel/packages/core/core/src/requests/ConfigRequest.js

Lines 136 to 165 in 9e5d055

// If there is no result hash set by the transformer, default to hashing the included

// files if any, otherwise try to hash the config result itself.

if (config.cacheKey == null) {

if (config.invalidateOnFileChange.size > 0) {

hash.writeString(

await getInvalidationHash(

[...config.invalidateOnFileChange].map(filePath => ({

type: 'file',

filePath,

})),

options,

),

);

} else if (config.result != null) {

try {

hash.writeBuffer(serializeRaw(config.result));

} catch (err) {

throw new ThrowableDiagnostic({

diagnostic: {

message:

'Config result is not hashable because it contains non-serializable objects. Please use config.setCacheKey to set the hash manually.',

origin: pluginName,

},

});

}

}

} else {

hash.writeString(config.cacheKey ?? '');

}

But there would ideally still be some way to pass non-serializable data here.

packages/core/core/src/requests/WriteBundlesRequest.js

parcel-benchmark · 2022-08-05T16:34:37Z

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.97s	-44.00ms
Cached	429.00ms	-20.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	107.00ms	-225.00ms 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	321.00ms	-19.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	322.00ms	-19.00ms 🚀
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	322.00ms	-20.00ms 🚀
dist/legacy/index.b8ae99ba.css	94.00b	+0.00b	333.00ms	-18.00ms 🚀
dist/modern/index.31cedca9.css	94.00b	+0.00b	332.00ms	-18.00ms 🚀

React HackerNews 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description	Time	Difference
Cold	9.03s	+218.00ms
Cached	345.00ms	-9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

mischnic · 2022-08-31T07:55:20Z

packages/core/core/src/PackagerRunner.js

+        searchPath: joinProjectPath(
+          bundle.target.distDir,
+          bundle.name ?? bundle.id,
+        ),


I think if name is null, then it's an inline bundle? Not sure what the searchPath should be in that case

packages/core/core/src/requests/ConfigRequest.js

Parcel v2.8.0 adds a BundleConfigType generic type to Optimizer (parcel-bundler/parcel#8370) as part of their `loadBundleConfig` method. We use a dummy type because we don't need this functionality currently.

* chore(deps): update parcel packages * Add dummy generic type so optimizer works with parcel v2.8.0+ Parcel v2.8.0 adds a BundleConfigType generic type to Optimizer (parcel-bundler/parcel#8370) as part of their `loadBundleConfig` method. We use a dummy type because we don't need this functionality currently. * Update snapshot tests for Parcel 2.8.3 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Grant Wong <gwong2@atlassian.com>

* Update 'ax' to accept short class name * Update 'ax' flow type and up the size limit * Add benchmark test to test ax(compressed class names) * Change the format of compress class names * Restore Flow type * Compress class names * Update snapshot * chore(deps): update dependency @types/node to ^18.11.19 (#1407) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Turn off compressing class names if stylesheet extraction is off * parcel integration * Add changeset * Replace rather than insert class name in the sheet and make ClassNames to support conditional CSS * add 'generateCompressionMap' * Update changelog * Fix spelling mistake * Allow uppercase in class-name-generator * chore(deps): update dependency css-what to >=5.1.0 (#1409) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update webpack packages (#1411) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix transparent and currentcolor not being treated as a color (#1412) * chore(deps): update dependency css-what to >=6.1.0 (#1414) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Version Packages (#1413) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update dependency nth-check to >=2.1.1 (#1415) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency prettier to ^2.8.4 (#1416) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to ^18.13.0 (#1417) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump node version to v18 (#1392) * Bump node version to v18 * Bump import jsx * Bump nvmrc node version from 18.12 to 18.14 * Add changeset for PR #1392 --------- Co-authored-by: Grant Wong <gwong2@atlassian.com> * chore(deps): update parcel packages (#1390) * chore(deps): update parcel packages * Add dummy generic type so optimizer works with parcel v2.8.0+ Parcel v2.8.0 adds a BundleConfigType generic type to Optimizer (parcel-bundler/parcel#8370) as part of their `loadBundleConfig` method. We use a dummy type because we don't need this functionality currently. * Update snapshot tests for Parcel 2.8.3 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Grant Wong <gwong2@atlassian.com> * chore(deps): update eslint packages (#1420) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to v29 (#1384) * chore(deps): update dependency jest to v29 * Update snapshots and node env for some tests --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jake Lane <jlane2@atlassian.com> * Add Grant Wong as codeowner (#1421) Co-authored-by: Grant Wong <2908767+dddlr@users.noreply.github.com> * Replace rather than insert class name in the sheet and make ClassNames to support conditional CSS * Add prefix option and avoid 'ad' * Add comment to ax benchmark * Make classNameCompressionMap a separate file in parcel example app * Remove default reservedClassNames * Export generateCompressionMap * Update comment --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jake Lane <jlane2@atlassian.com> Co-authored-by: atlas-dst-bot <81662413+atlas-dst-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Grant Wong <gwong2@atlassian.com> Co-authored-by: Grant Wong <2908767+dddlr@users.noreply.github.com>

mischnic commented Aug 5, 2022

View reviewed changes

packages/core/core/src/requests/WriteBundlesRequest.js Outdated Show resolved Hide resolved

mischnic force-pushed the loadGlobalInfo branch from f4ad93e to ff8d262 Compare August 5, 2022 15:56

mischnic added 3 commits August 24, 2022 19:45

Different API for config loading

abc984a

Rename loadBundleConfig

792963d

Pass in public config

1971271

mischnic force-pushed the loadGlobalInfo branch from ff8d262 to 1971271 Compare August 24, 2022 17:52

mischnic added 4 commits August 24, 2022 20:06

invalidateOnBuild

52e1d32

Typed runPackage invocation

c465483

Add test

84385ae

Fixup invalidations

0f80a57

mischnic commented Aug 31, 2022

View reviewed changes

Cleanup

a301c37

devongovett reviewed Sep 6, 2022

View reviewed changes

packages/core/core/src/requests/ConfigRequest.js Outdated Show resolved Hide resolved

devongovett approved these changes Sep 6, 2022

View reviewed changes

mischnic added 2 commits September 6, 2022 09:37

Fix variable name

ad2e110

Merge branch 'v2' into loadGlobalInfo

c7624a9

devongovett approved these changes Sep 7, 2022

View reviewed changes

devongovett merged commit 65500fb into v2 Sep 7, 2022

devongovett deleted the loadGlobalInfo branch September 7, 2022 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache invalidations for packagers when reading other bundles #8370

Cache invalidations for packagers when reading other bundles #8370

mischnic commented Aug 5, 2022 •

edited

mischnic Aug 5, 2022 •

edited

parcel-benchmark commented Aug 5, 2022 •

edited

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic Aug 31, 2022

		// TODO expose config and let plugin set key?
		config.cacheKey = hashString(JSON.stringify(config.result) ?? '');


	// If there is no result hash set by the transformer, default to hashing the included
	// files if any, otherwise try to hash the config result itself.
	if (config.cacheKey == null) {
	if (config.invalidateOnFileChange.size > 0) {
	hash.writeString(
	await getInvalidationHash(
	[...config.invalidateOnFileChange].map(filePath => ({
	type: 'file',
	filePath,
	})),
	options,
	),
	);
	} else if (config.result != null) {
	try {
	hash.writeBuffer(serializeRaw(config.result));
	} catch (err) {
	throw new ThrowableDiagnostic({
	diagnostic: {
	message:
	'Config result is not hashable because it contains non-serializable objects. Please use config.setCacheKey to set the hash manually.',
	origin: pluginName,
	},
	});
	}
	}
	} else {
	hash.writeString(config.cacheKey ?? '');
	}

Cache invalidations for packagers when reading other bundles #8370

Cache invalidations for packagers when reading other bundles #8370

Conversation

mischnic commented Aug 5, 2022 • edited

mischnic Aug 5, 2022 • edited

Choose a reason for hiding this comment

parcel-benchmark commented Aug 5, 2022 • edited

Benchmark Results

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic Aug 31, 2022

Choose a reason for hiding this comment

mischnic commented Aug 5, 2022 •

edited

mischnic Aug 5, 2022 •

edited

parcel-benchmark commented Aug 5, 2022 •

edited