Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release frame-omni-bencher #4354

Closed
4 tasks
bkontur opened this issue May 2, 2024 · 6 comments · Fixed by #4557 · May be fixed by #4405
Closed
4 tasks

Release frame-omni-bencher #4354

bkontur opened this issue May 2, 2024 · 6 comments · Fixed by #4557 · May be fixed by #4405

Comments

@bkontur
Copy link
Contributor

bkontur commented May 2, 2024

I have a PoC for using frame-omni-bencher in the fellows repo: polkadot-fellows/runtimes#298. However, since there is no released version, I have to build it from the sources each time for every runtime pipeline, which is a waste of resources.

How to re-use frame-omni-bencher for fellows or elsewhere:

  • create a github action for that, as we have for try-runtime-gha e.g. used here
  • release for cargo install, e.g. as we have for zepter, cargo install --locked -q zepter
  • release just as binary to polkadot-sdk repo/release, so we just setup downloading from polkadot-sdk in fellows CI?
  • other?

cc: @ggwpez
@ggwpez
Copy link
Member

ggwpez commented May 2, 2024

How long is the build time?
Binary release is probably the fastest for CI. AFAIK the GHA for try-runtime is also doing that.

@EgorPopelyaev do you know what would be the steps to attach another binary to the release?

@bkontur
Copy link
Contributor Author

bkontur commented May 2, 2024

How long is the build time?

@ggwpez https://github.com/polkadot-fellows/runtimes/actions/runs/8923074053/job/24506630345?pr=298#step:11:1001

 Compiling frame-omni-bencher v0.1.0 (/home/runner/work/runtimes/runtimes/polkadot-sdk/substrate/utils/frame/omni-bencher)
    Finished release [optimized] target(s) in 14m 16s

@EgorPopelyaev
Copy link
Contributor

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

@bkontur
Copy link
Contributor Author

bkontur commented May 7, 2024

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

ok, thank you, I will check later,
and also I will change short-benchmarks to use frame-omni-bencher instead of ./artifacts/polkadot

@bkontur bkontur mentioned this issue May 7, 2024
Draft
6 tasks
@bkontur
Copy link
Contributor Author

bkontur commented May 14, 2024

Hey @bkontur @ggwpez, if there will be a github flow or job which builds the binary. I could integrate it in this flow, which creates release draft, the same way how it is done with runtimes

@EgorPopelyaev I added job that should build that binary here: https://github.com/paritytech/polkadot-sdk/pull/4405/files#diff-56213afe4ff9406795cf7f877c62e3f277dc7edaeccef4a26260f50f776663f0
but I haven't tested it, I don't know how exactly and I don't want to trigger draft release, can you please check/test it and also could you please help with integrating it to release?

@kianenigma
Copy link
Contributor

would it not be possible to create a CI image that already has this stuff installed? That seems like the more correct solution to me.

@bkontur bkontur mentioned this issue May 24, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
89604da 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `polkadot-sdk@1.12` release

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev added a commit that referenced this issue May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
320cea6 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `polkadot-sdk@1.12` release

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
EgorPopelyaev added a commit that referenced this issue May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
77cf446 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `polkadot-sdk@1.12` release

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kianenigma @EgorPopelyaev @bkontur @ggwpez