Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prospective-parachains subsystem from collator nodes #4429

Closed
alindima opened this issue May 10, 2024 · 0 comments · Fixed by #4471
Closed

Remove prospective-parachains subsystem from collator nodes #4429

alindima opened this issue May 10, 2024 · 0 comments · Fixed by #4471
Assignees
@alindima
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@alindima
Copy link
Contributor

This is not really needed and brings a serious performance hit for collators which connect to RPC nodes.

See this discussion: #4167 (comment)
@alindima alindima added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label May 10, 2024
@alindima alindima self-assigned this May 10, 2024
@alindima alindima mentioned this issue May 15, 2024
Merged
1 task
@alindima alindima linked a pull request May 15, 2024 that will close this issue
Remove the prospective-parachains subsystem from collators #4471
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
@alindima
Remove the prospective-parachains subsystem from collators (#4471)
278486f 
Implements #4429

Collators only need to maintain the implicit view for the paraid they
are collating on.
In this case, bypass prospective-parachains entirely. It's still useful
to use the GetMinimumRelayParents message from prospective-parachains
for validators, because the data is already present there.

This enables us to entirely remove the subsystem from collators, which
consumed resources needlessly

Aims to resolve #4167 

TODO:
- [x] fix unit tests
Ank4n pushed a commit that referenced this issue May 21, 2024
@alindima @Ank4n
Remove the prospective-parachains subsystem from collators (#4471)
a771851 
Implements #4429

Collators only need to maintain the implicit view for the paraid they
are collating on.
In this case, bypass prospective-parachains entirely. It's still useful
to use the GetMinimumRelayParents message from prospective-parachains
for validators, because the data is already present there.

This enables us to entirely remove the subsystem from collators, which
consumed resources needlessly

Aims to resolve #4167 

TODO:
- [x] fix unit tests
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this issue May 27, 2024
@alindima @TomaszWaszczyk
Remove the prospective-parachains subsystem from collators (paritytec…
36522cc 
…h#4471)

Implements paritytech#4429

Collators only need to maintain the implicit view for the paraid they
are collating on.
In this case, bypass prospective-parachains entirely. It's still useful
to use the GetMinimumRelayParents message from prospective-parachains
for validators, because the data is already present there.

This enables us to entirely remove the subsystem from collators, which
consumed resources needlessly

Aims to resolve paritytech#4167 

TODO:
- [x] fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alindima alindima

Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the prospective-parachains subsystem from collators paritytech/polkadot-sdk
1 participant
@alindima