Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metrics helpers #196

Open
pepoviola opened this issue Mar 23, 2024 · 0 comments
Open

Refactor metrics helpers #196

pepoviola opened this issue Mar 23, 2024 · 0 comments

Comments

@pepoviola
Copy link
Collaborator

At the moment the Node instance you get from the running network expose two methods assert and assert_with (the first assert the equality and the latest accept a closure as predicate), at first the naming is not great and those can be changed to clearly express what are the goal of them.
Also, a couple of methods to add are:

 // expose a _wait_ method to allow users to wait until the condition is met.
 async fn wait_for_metric(metric, predicate, [timeout]) -> Result<bool>  
// expose the raw metrics from prometheus with the labels as hashmap
// RawMetricHash should hold both labels (as inner hashMap) and value
async fn raw_metrics() -> Result<RawMetricHash>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant