Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config options like --port, --config are ignored since v4.1.1 #2112

Closed
4 tasks done
bugra9 opened this issue May 3, 2022 · 4 comments
Closed
4 tasks done

Config options like --port, --config are ignored since v4.1.1 #2112

bugra9 opened this issue May 3, 2022 · 4 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@bugra9
Copy link
Contributor

bugra9 commented May 3, 2022

New Issue Checklist

Issue Description

Can't start parse-dashboard with options like --port, --config.

  • parse-dashboard v4.1.0 is dependent on commander.js v6.2.1
  • parse-dashboard v4.1.1 is dependent on commander.js v9.0.0.

https://github.com/tj/commander.js/releases/tag/v7.0.0
Breaking: options are stored safely by default, not as properties on the command (tj/commander.js#1409)

  • this especially affects accessing options on program, use program.opts()
  • revert behaviour with .storeOptionsAsProperties()

Steps to reproduce

./node_modules/.bin/parse-dashboard --port 4041

Actual Outcome

The dashboard is now available at http://0.0.0.0:4040/

Expected Outcome

The dashboard is now available at http://0.0.0.0:4041/

Environment

Dashboard

  • Parse Dashboard version: 4.4.1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Firefox
  • Browser version: 99.0.1

Server

  • Parse Server version: 5.2.1
  • Operating system: Arch Linux
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: 5.0.8
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): Local

Logs

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 3, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label May 3, 2022
@piyushbeli
Copy link

It also does not take the config file into the consideration. that said it will always try to run with default settings.

@mtrezza
Copy link
Member

mtrezza commented May 6, 2022

Thanks for pointing this out, would you want to open a PR and try to fix this?

@mtrezza mtrezza pinned this issue May 6, 2022
@mtrezza mtrezza changed the title Can't start parse-dashboard with options like --port, --config (v4.1.1) Config options like --port, --config are ignored since v4.1.1 May 6, 2022
@mtrezza
Copy link
Member

mtrezza commented May 7, 2022

Closing via #2113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

3 participants