Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keyboard accessibility is broken in filter dialog in data browser #2482

Draft
wants to merge 5 commits into
base: alpha
Choose a base branch
from

Conversation

AshishBarvaliya
Copy link
Member

Issue Description

Closes: #2469

Approach

The keyboard accessibility code was present, but unfortunately, it wasn't functioning due to a bug.

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jun 27, 2023

Uffizzi Ephemeral Environment deployment-29584

⌚ Updated Jun 27, 2023, 21:42 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2482

📄 View Application Logs etc.

What is Uffizzi? Learn more

@AshishBarvaliya
Copy link
Member Author

I have implemented the basic selection functionality, such as moving up, down, and using the enter key for selection. However, I will make the necessary updates as per your suggested flow.

  1. Hit key F -> filter dialog opens.
  2. Enter em -> fields email and email2 shows in list.
  3. Hit arrow down key -> field email is selected.
  4. Hit Enter key -> search filter is applied (like clicking the "Apply" button)

source: #2478

@mtrezza
Copy link
Member

mtrezza commented Jun 27, 2023

The keyboard accessibility code was present, but unfortunately, it wasn't functioning due to a bug.

Hah, who would have thought! Thanks for looking into this.

@mtrezza mtrezza changed the title fix: Keyboard accessibility for Autocomplete fields fix: Keyboard accessibility is broken in filter dialog in data browser Jun 28, 2023
@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2023

Could you also add that when hitting the Tab key the focus jumps from the filter text input field to the condition field? See step 4 below:

  1. Hit key F -> filter dialog opens.
  2. Enter em -> fields email and email2 shows in list.
  3. Hit arrow down key -> field email is selected.
  4. Hit Tab key -> condition field is in focus and drop down opens ("key exists", "key does not exist", etc.)

For me it currently sets the focus to the browser address bar when hitting Tab.

And could you change the selection style from the current dark blue text color to only changing the background color of the selected field? I would use one of the blue colors that we already have.

image

@AshishBarvaliya AshishBarvaliya marked this pull request as draft June 30, 2023 01:11
@mtrezza
Copy link
Member

mtrezza commented Jul 16, 2023

@AshishBarvaliya Could you resolve the conflicts so we can get this ready for merge?

@mtrezza
Copy link
Member

mtrezza commented Apr 19, 2024

@AshishBarvaliya Do you think we could get this merged? It seems to be ready, just the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filters dropdown is currently inaccessible via arrow keys.
2 participants