You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #999 argued in favor of using MeshBlockData<Real> *mbd function arguments for a newly added PostInitializaiton hook. This inspired some discussion regarding consistency between hook function arguments.
For example, many hooks take MeshData<Real> or MeshBlockData<Real> arguments (which comes with the nicety that downstream users can template on typename to interface with both). However, the MeshBlock variation of ProblemGenerator is somewhat unique in that it takes *pmb (the Mesh variation takes as argument MeshData<Real>).
Here, I propose that we try to enforce some form of consistency between hook function arguments. In the example above, I'd advocate for requiring the MeshBlock variation of ProblemGenerators take MeshBlockData<Real> as function argument. Of course, this would be a breaking change... requiring downstream users to update all their pgen.
The text was updated successfully, but these errors were encountered:
PR #999 argued in favor of using
MeshBlockData<Real> *mbd
function arguments for a newly addedPostInitializaiton
hook. This inspired some discussion regarding consistency between hook function arguments.For example, many hooks take
MeshData<Real>
orMeshBlockData<Real>
arguments (which comes with the nicety that downstream users cantemplate
ontypename
to interface with both). However, theMeshBlock
variation ofProblemGenerator
is somewhat unique in that it takes*pmb
(theMesh
variation takes as argumentMeshData<Real>
).Here, I propose that we try to enforce some form of consistency between hook function arguments. In the example above, I'd advocate for requiring the
MeshBlock
variation ofProblemGenerator
s takeMeshBlockData<Real>
as function argument. Of course, this would be a breaking change... requiring downstream users to update all their pgen.The text was updated successfully, but these errors were encountered: