Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenienience: access to all base blocks and partition by number of packs #1003

Open
pgrete opened this issue Feb 1, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@pgrete
Copy link
Collaborator

pgrete commented Feb 1, 2024

The "base" MeshData container may not be populated by default and we have a couple of places in the code where we need all "base" blocks in a single container (currently safeguarded by GetOrAdd("base",0) with a check for num_partitions=1 (i.e., pack_size=1).
The nicer option would be to introduce a GetOrAddAll that puts all blocks in a single container.

Separately, it would be nice to specify the number of packs rather than the pack size as this would allow for more flexible partitioning in particular for simulations with varying number of blocks.

@pgrete pgrete added the enhancement New feature or request label Feb 1, 2024
@pgrete pgrete self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant