You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that some functionality may depend on proper results of isnan, infinity etc, which may, or may not, work as expected when the code basis is compiled with too much optimization (e.g., -ffast-math), which is, for example, the default in the original Athena++.
It may be worth to add a check at compile time, if the resulting binary works as expected with regard to these use cased and otherwise warn/fail/override.
The text was updated successfully, but these errors were encountered:
I noticed that some functionality may depend on proper results of
isnan
, infinity etc, which may, or may not, work as expected when the code basis is compiled with too much optimization (e.g.,-ffast-math
), which is, for example, the default in the original Athena++.It may be worth to add a check at compile time, if the resulting binary works as expected with regard to these use cased and otherwise warn/fail/override.
The text was updated successfully, but these errors were encountered: