Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for support of isnan infty etc. #1005

Open
pgrete opened this issue Feb 5, 2024 · 0 comments
Open

Check for support of isnan infty etc. #1005

pgrete opened this issue Feb 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pgrete
Copy link
Collaborator

pgrete commented Feb 5, 2024

I noticed that some functionality may depend on proper results of isnan, infinity etc, which may, or may not, work as expected when the code basis is compiled with too much optimization (e.g., -ffast-math), which is, for example, the default in the original Athena++.
It may be worth to add a check at compile time, if the resulting binary works as expected with regard to these use cased and otherwise warn/fail/override.

@pgrete pgrete added the enhancement New feature or request label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant