Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn or error on failed variable load on restarts #1059

Open
pgrete opened this issue Apr 18, 2024 · 0 comments
Open

Warn or error on failed variable load on restarts #1059

pgrete opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pgrete
Copy link
Collaborator

pgrete commented Apr 18, 2024

It looks like I never opened an issue about it, but I've been stung by Parthenon only warning on variables not found, too. IIRC this was partially because any read error (not just absence in the file) just generates the warning rather than a real error, which made it hard to debug restarting from face-centered fields, for example.

There are valid reasons to start with more Restart variables configured than are present in the restart file: in KHARMA for example, we'll evolve ideal MHD to some time, then switch to slower extended/viscous modeling once the run is far enough in that it matters. But, I think we should at least pare down the situations where this is allowed, e.g. only for restarts with a new input file, or only with some flag parthenon/job/restart_errors=warn set.

Originally posted by @bprather in #1046 (comment)

@pgrete pgrete added the enhancement New feature or request label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant