Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that user defined fields/swarms/etc. don't include :: in their names #1065

Open
lroberts36 opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lroberts36
Copy link
Collaborator

Currently, we reserve internal_varname_separator = "::" for places where parthenon internally adds stuff to field names (e.g. "bnd_flux::" + other_name and when variables are private to a package). Right now, we don't actually check that user defined variable names don't include ::. It would be good to have this check, but it is a little challenging to add because of the way package resolution works, as fields get added by users and internally using the same functions.

@lroberts36 lroberts36 added the enhancement New feature or request label Apr 26, 2024
@lroberts36 lroberts36 changed the title Enforce that user defined fields/swarms/etc. don't include '::' in their names Enforce that user defined fields/swarms/etc. don't include :: in their names Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants