Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D par_reduce missing #1075

Closed
brryan opened this issue May 14, 2024 · 2 comments · Fixed by #1078
Closed

1D par_reduce missing #1075

brryan opened this issue May 14, 2024 · 2 comments · Fixed by #1078

Comments

@brryan
Copy link
Collaborator

brryan commented May 14, 2024

parthenon::par_reduce() over one dimension does not compile for me downstream. I assume we're just missing a specialization in kokkos_abstraction.hpp but I couldn't immediately work out the solution.
@Yurlungur Yurlungur mentioned this issue May 16, 2024
Merged
12 tasks
@Yurlungur Yurlungur linked a pull request May 16, 2024 that will close this issue
A few Kokkos quality of life improvements #1078
Merged
12 tasks
@Yurlungur
Copy link
Collaborator

@brryan see #1078

@brryan
Copy link
Collaborator Author

brryan commented May 16, 2024

That solves my downstream problem thanks @Yurlungur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A few Kokkos quality of life improvements parthenon-hpc-lab/parthenon
2 participants
@Yurlungur @brryan