New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uploadProductFirmware only tests with Buffer, and doesn't test with filename #114

Open

dmiddlecamp opened this issue Feb 4, 2020 · 1 comment

Contributor

dmiddlecamp commented Feb 4, 2020

in the documentation:

options.file Object Path or Buffer of the new firmware file
                             Either a path or Buffer of the file contents in Node, or a File or Blob in the browser.

test parameter appears to only set file to a buffer, and not a path
file: new Buffer('ELF...'),

discovered because upload with path appears to not work as expected during testing / development.

The text was updated successfully, but these errors were encountered:

Contributor Author

dmiddlecamp commented Feb 4, 2020 •

edited

(stream of consciousness, still investigating)

it looks like maybe this isn't working in the browser (maybe just chrome / firefox), seems like it really expects a blob and not a path...

https://github.com/particle-iot/particle-api-js/blob/master/src/Agent.js#L139-L153

Am I correct in thinking this functionality just wasn't tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment