-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong protocol on local server? #682
Comments
Great catch, that's probably it. Fix incoming: #683 |
Fix available on |
Thanks! |
While integrating Docker containers, I encountered an issue where connections default to WSS despite specifying an HTTP URL in For now, as a workaround, I am specifying explicitly in constructor: const provider = new YPartyKitProvider(
Deno.env.get('PARTY_KIT_URL'),
record.id,
yDoc,
{ protocol: "ws" }
); I believe this could improve usability for scenarios involving Docker container connections. Is reopening the issue for further discussion or consideration possible? |
This is a good idea. Happy to take a PR |
When running
npx partykit dev
, the worker is hosted at three endpoints:However, the third endpoint (
http://192.168.0.214:1999
) does not work because the "wss" protocol is used. This makes a server difficult to debug on a local network.I think the following code is to blame:
partykit/packages/partysocket/src/index.ts
Lines 88 to 92 in 5ba5c33
I've been unable to successfully patch the code to find out, but that's my guess!
The text was updated successfully, but these errors were encountered: