Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTful API's exposed by Pathway - should tolerate trailing slash in endpoint URI? #12

Open
dxtrous opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request priority:low Triaged: low priority issue

Comments

@dxtrous
Copy link
Member

dxtrous commented Mar 14, 2024

Is your feature request related to a problem? Please describe.

Many (most?) RESTful API endpoints out there tolerate a trailing slash or not, e.g.:
https://www.codever.dev/api/public/bookmarks - 200 OK
https://www.codever.dev/api/public/bookmarks/ - 200 OK
Giving a 30X is a possibility, but usually both work identically either way.

Pathway RESTful API's don't seem to allow a trailing slash at all.

https://demo-document-indexing.pathway.stream/v1/statistics - 200 OK
https://demo-document-indexing.pathway.stream/v1/statistics/ - 404 Not found

Describe the solution you'd like
Discuss if the trailing-slash version should also work, and if so, as 30X or transparent 200.
Take into account implications for route caching, etc., in the decision.
If not, leave current behavior as is, and document.
Either way, add explanation to docs.

Describe alternatives you've considered
None

Additional context
Originally reported by user Hemant on Discord: https://discord.com/channels/1042405378304004156/1047451777940852736/1217801242760314893

@dxtrous dxtrous added enhancement New feature or request priority:low Triaged: low priority issue labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Triaged: low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants