Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Mustache as default engine #1239

Open
JosefBredereck opened this issue Aug 18, 2020 · 0 comments · Fixed by #1457 · May be fixed by #1455
Open

Deprecate Mustache as default engine #1239

JosefBredereck opened this issue Aug 18, 2020 · 0 comments · Fixed by #1457 · May be fixed by #1455
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior core pinned 📌 Don't let stalebot clean this up
Projects
core 2 🧨

Comments

@JosefBredereck
Copy link
Contributor

JosefBredereck commented Aug 18, 2020 •
edited by mfranzke

Converted from https://github.com/orgs/pattern-lab/projects/3

https://patternlab.io/docs/including-patterns/

This feature creates PL-lockin and too much maintenance effort.

see #834
@JosefBredereck JosefBredereck added pinned 📌 Don't let stalebot clean this up core breaking ❗ Use this labe if the change will break the current pattern lab behavior labels Aug 18, 2020
@JosefBredereck JosefBredereck added this to To do in core 2 🧨 via automation Aug 18, 2020
@mfranzke mfranzke linked a pull request Dec 25, 2022 that will close this issue
Draft
@mfranzke mfranzke linked a pull request Dec 25, 2022 that will close this issue
refactor: remove mustache in favour of handlebars #1455
Draft
This was referenced Dec 26, 2022
Merged
Closed
core 2 🧨 automation moved this from To do to Done Dec 28, 2022
@mfranzke mfranzke reopened this Dec 30, 2022
core 2 🧨 automation moved this from Done to In progress Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior core pinned 📌 Don't let stalebot clean this up
Projects
core 2 🧨
  
In progress
Milestone
No milestone
2 participants
@mfranzke @JosefBredereck