Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Coding Standards (DIRECTORY_SEPARATOR) #147

Open
sghoweri opened this issue Oct 28, 2017 · 0 comments
Open

Clarify Coding Standards (DIRECTORY_SEPARATOR) #147

sghoweri opened this issue Oct 28, 2017 · 0 comments

Comments

@sghoweri
Copy link
Contributor

sghoweri commented Oct 28, 2017

@EvanLovely specifically, which of these is "correct" here? Do we actually need / use / require DIRECTORY_SEPARATOR still? Is there a better way to handle this sort of thing?

// PatternInfoRule.php
$filePath = Config::getOption("patternSourceDir")."/".$pathName;`
// PsuedoPatternRule.php
$filePath = Config::getOption("patternSourceDir").DIRECTORY_SEPARATOR.$pathName;`
// DocumentationRule.php
$patternSourceDir = Config::getOption("patternSourceDir");
$filePath = $patternSourceDir.DIRECTORY_SEPARATOR.$pathName;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant