Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Adopt Symfony coding stardards #150

Open
aleksip opened this issue Oct 30, 2017 · 5 comments
Open

Proposal: Adopt Symfony coding stardards #150

aleksip opened this issue Oct 30, 2017 · 5 comments

Comments

@aleksip
Copy link
Member

aleksip commented Oct 30, 2017

Pattern Lab PHP uses many Symfony components, so it might make sense to adopt their coding standards. They also have a nice tool, the PHP Coding Standards Fixer, which we could run on our entire PHP codebase.

@sghoweri
Copy link
Contributor

sghoweri commented Nov 2, 2017

^ and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained.

@aleksip at a high level, what sort of things would adopting Symphony's coding standards change? Please oh please oh please don't say we need to switch back over to using tabs 😜

@EvanLovely
Copy link
Member

Love this

@aleksip
Copy link
Member Author

aleksip commented Nov 2, 2017

and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained

Indeed! Actually, I have some secret plans related to this I'm hoping to advance next week. 😉

Please oh please oh please don't say we need to switch back over to using tabs

Symfony follows PSR-2 which dictates that code MUST use 4 spaces for indenting, not tabs!

@EvanLovely
Copy link
Member

secret plans

😳🤔

@aleksip
Copy link
Member Author

aleksip commented Nov 2, 2017

Not evil ones, I promise! 😈 😄

Just planning to find out if some custom PL code could be replaced with a drop in Symfony replacement with no side effects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants