Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Twig-specific code from core to patternengine-php-twig #158

Open
aleksip opened this issue Nov 20, 2017 · 1 comment
Open

Move Twig-specific code from core to patternengine-php-twig #158

aleksip opened this issue Nov 20, 2017 · 1 comment
Assignees
@sghoweri

Comments

@aleksip
Copy link
Member

aleksip commented Nov 20, 2017

LineageHelper has some special handling for Twig. We should move this to patternengine-php-twig as core should be templating engine agnostic.

I think this should be possible to do by adding a PatternLabListener.php to patternengine-php-twig and hooking into patternData.lineageHelperStart or patternData.lineageHelperEnd.

@sghoweri Would you like to have a go at this? :)
@aleksip aleksip mentioned this issue Nov 20, 2017
Open
@sghoweri
Copy link
Contributor

Sounds like something right up my alley 🙂

If you could reassign this to me I can take care of this this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sghoweri sghoweri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleksip @sghoweri