Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\PatternLab\Config::setOption() won't set to a falsey value #172

Open
andriokha opened this issue Mar 9, 2019 · 0 comments
Open

\PatternLab\Config::setOption() won't set to a falsey value #172

andriokha opened this issue Mar 9, 2019 · 0 comments

Comments

@andriokha
Copy link

Hi,

Thanks for this fantastic product!!

I'm new to PL and in writing a listener plugin I wanted to create a test that could update a configuration option to false. It doesn't work because at the start of \PatternLab\Config::setOption() there's this:

if (empty($optionName) || empty($optionValue)) {
return false;
}

Also \PatternLab\Config::updateOption() just passes through to ::setOption().

It's quite an explicit check, so I guess it is/was there for a reason, but I'm not sure what that might be (:

Is that a bug? Am I doing things wrong?!

TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant