Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1:1]: pf-alert #2539

Open
Arathy-s opened this issue Jul 7, 2023 · 3 comments · May be fixed by #2593
Open

[1:1]: pf-alert #2539

Arathy-s opened this issue Jul 7, 2023 · 3 comments · May be fixed by #2593
Assignees
@brianferry
Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language new component request priority: low Severity level: 3

Comments

@Arathy-s
Copy link
Collaborator

Arathy-s commented Jul 7, 2023 •
edited by bennypowers

Component name: pf-alert

An alert is used to display notifications or messages to users. It provides time-sensitive information about events that occur while an application is running and is typically used for important or critical notifications that require user attention.

Screenshot 2023-07-07 at 1 02 07 PM

Design specification

The design specifications should match with https://v4-archive.patternfly.org/v4/components/alert/design-guidelines.

Accessibility

The component should implement all the accessibility features as https://v4-archive.patternfly.org/v4/components/alert.
@Arathy-s Arathy-s added design system Updates or issues to align components to the Red Hat Design System. new component request priority: low Severity level: 3 labels Jul 7, 2023
@bennypowers
Copy link
Member

we have prior art in rh-alert that we might be able to rely on here

@bennypowers bennypowers added the good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language label Jul 9, 2023
@bennypowers bennypowers added the 1:1 Aligning components with PatternFly v4 label Jul 31, 2023
@brianferry brianferry self-assigned this Aug 30, 2023
@brianferry
Copy link
Collaborator

Currently a work in progress, have the following added:

pf-alert with similar markdown / api to rh-alert, so far:

variants:
custom, info, success, warning, danger

attributes:
inline, dismissable, timeout, truncated

@bennypowers
Copy link
Member

@brianferry would you please open a draft pr and link to this issue?

@brianferry brianferry linked a pull request Sep 19, 2023 that will close this issue
Draft
@brianferry brianferry linked a pull request Sep 19, 2023 that will close this issue
feat(alert): add pf-alert #2593
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianferry brianferry

Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language new component request priority: low Severity level: 3
Projects
Roadmap
Status: In Progress - on schedule
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(alert): add pf-alert patternfly/patternfly-elements
3 participants
@bennypowers @brianferry @Arathy-s