Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BaseAccordion* #2612

Open
bennypowers opened this issue Oct 19, 2023 · 2 comments · May be fixed by #2764
Open

Remove BaseAccordion* #2612

bennypowers opened this issue Oct 19, 2023 · 2 comments · May be fixed by #2764
Assignees
@bennypowers
Labels
pfe 4.0 For PFE version 4.0 (breaking change)
Milestone
PatternFly Elemen...

Comments

@bennypowers
Copy link
Member

bennypowers commented Oct 19, 2023 •
edited

Affects <rh-accordion>
@bennypowers bennypowers added this to the PatternFly Elements 3 milestone Oct 19, 2023
@bennypowers bennypowers self-assigned this Oct 19, 2023
@bennypowers
Copy link
Member Author

bennypowers commented Oct 19, 2023 •
edited

@zeroedin I think this should work should be done in consideration of #2624 and #2577. in other words, tabs controller and baseaccordion have significant overlap

@markcaron markcaron added the pfe 4.0 For PFE version 4.0 (breaking change) label Oct 19, 2023
@zeroedin
Copy link
Collaborator

zeroedin commented Nov 1, 2023

@zeroedin I think this should work should be done in consideration of #2624 and #2577. in other words, tabs controller and baseaccordion have significant overlap

I did some work on #2577 today just to get it in line with expectations for 3.0 organizing and putting the tabs controller under core. I can start looking at abstracting whatever we call this new controller that is shared between tabs and accordion now I think a bit more clearly.

bennypowers added a commit that referenced this issue May 23, 2024
@bennypowers
fix(accordion)!: remove BaseAccordion
31c1de0 
Closes #2612
@bennypowers bennypowers linked a pull request May 23, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennypowers bennypowers

Labels
pfe 4.0 For PFE version 4.0 (breaking change)
Projects
None yet
Milestone
PatternFly Elements 4
Development

Successfully merging a pull request may close this issue.

fix(accordion)!: remove BaseAccordion patternfly/patternfly-elements
3 participants
@zeroedin @bennypowers @markcaron