Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert update to ParseMD and investigate ESM compatible solution #4005

Open
jenny-s51 opened this issue May 6, 2024 · 0 comments
Open

Revert update to ParseMD and investigate ESM compatible solution #4005

jenny-s51 opened this issue May 6, 2024 · 0 comments
Assignees

Comments

@jenny-s51
Copy link
Contributor

Is this a new page or a change to an existing one?
Revert the change made in https://github.com/patternfly/patternfly-org/pull/4004/files#diff-97bd431987a2e7dda0f66ad7f07ac6cf4eeebf21fbe44a1b45ef905968aa14caR207

Describe the enhancement

In order to get Typescript 4.7.4 to work in v6 with the visit function, we will have to investigate some potential approaches.

This may involve:

  • Upgrading to use ESM throughout org and generally moving away from CommonJS

or

  • Investigating if we can use another set of tools instead of unist-util to avoid any ESM-related issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Status: In Progress
Development

No branches or pull requests

2 participants