Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify & resolve any custom styles #3945

Closed
Tracked by #3764
kmcfaul opened this issue Mar 27, 2024 · 1 comment · Fixed by #4011
Closed
Tracked by #3764

Identify & resolve any custom styles #3945

kmcfaul opened this issue Mar 27, 2024 · 1 comment · Fixed by #4011
Assignees
@wise-king-sullyman
Labels
P1 ⭐
Milestone
Penta alpha omega...

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Mar 27, 2024 •
edited by mcoker

We should be able to remove all the CSS copied from core's pf-v6-c-content: https://github.com/patternfly/patternfly-org/blob/v6/packages/documentation-framework/templates/mdx.css#L90.

Looks like we can remove custom styles for the sidebar nav, which should resolve this issue #3953
@kmcfaul kmcfaul mentioned this issue Mar 27, 2024
Open
@nicolethoen nicolethoen added this to the Penta alpha omega release milestone Mar 28, 2024
@mcoker
Copy link
Contributor

mcoker commented Mar 28, 2024

Once patternfly/patternfly#5966 is complete, assuming those styles are pretty much a copy of the core pf-[v]-c-content (aka, react <Text> and <TextContent>) component, ideally, we should be able to yank out those styles and swap .ws-[p/dl/hr/etc] with classes from the content/text/textcontent component - eg, .pf-v6-c-content--[p/dl/hr/etc].

@mcoker mcoker mentioned this issue Apr 4, 2024
Closed
This was referenced May 3, 2024
Merged
Merged
@kmcfaul kmcfaul linked a pull request May 9, 2024 that will close this issue
fix(styles): Replace workspace styles with content classes #4011
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
P1 ⭐
Projects
PatternFly Issues
Status: Done
Milestone
Penta alpha omega release
Development

Successfully merging a pull request may close this issue.

fix(styles): Replace workspace styles with content classes wise-king-sullyman/patternfly-org
5 participants
@wise-king-sullyman @nicolethoen @jessiehuff @mcoker @kmcfaul