From fe40f19058a383cfc12e3f7a07d07af8dc579d04 Mon Sep 17 00:00:00 2001 From: Michael Coker <35148959+mcoker@users.noreply.github.com> Date: Mon, 7 Nov 2022 14:39:58 -0600 Subject: [PATCH] fix(bulk-select): fixed toggle spacing (#8326) * fix(bulk-select): fixed toggle spacing * chore(bulkselect): pr feedback --- packages/react-core/src/demos/Card/Card.md | 5 +++-- packages/react-core/src/demos/PrimaryDetail.md | 10 ++++------ packages/react-table/src/docs/demos/Table.md | 5 +++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/react-core/src/demos/Card/Card.md b/packages/react-core/src/demos/Card/Card.md index 7885236dcc2..84996a76734 100644 --- a/packages/react-core/src/demos/Card/Card.md +++ b/packages/react-core/src/demos/Card/Card.md @@ -426,11 +426,12 @@ class CardViewBasic extends React.Component { aria-label={anySelected ? 'Deselect all' : 'Select all'} isChecked={areAllSelected} onClick={this.splitCheckboxSelectAll.bind(this)} - > + > + {numSelected !== 0 && `${numSelected} selected`} + ]} onToggle={this.onSplitButtonToggle} > - {numSelected !== 0 && {numSelected} selected} } isOpen={splitButtonDropdownIsOpen} diff --git a/packages/react-core/src/demos/PrimaryDetail.md b/packages/react-core/src/demos/PrimaryDetail.md index 99aaaec6bdc..07c12fd4941 100644 --- a/packages/react-core/src/demos/PrimaryDetail.md +++ b/packages/react-core/src/demos/PrimaryDetail.md @@ -1369,14 +1369,12 @@ class PrimaryDetailCardView extends React.Component { aria-label={anySelected ? 'Deselect all' : 'Select all'} isChecked={areAllSelected} onClick={this.splitCheckboxSelectAll} - > + > + {numSelected !== 0 && `${numSelected} selected`} + ]} onToggle={this.onSplitButtonToggle} - > - {numSelected !== 0 && ( - {allSelected ? this.state.totalItemCount : numSelected} selected - )} - + > } isOpen={splitButtonDropdownIsOpen} dropdownItems={splitButtonDropdownItems} diff --git a/packages/react-table/src/docs/demos/Table.md b/packages/react-table/src/docs/demos/Table.md index 06cce291b51..1d2503cde33 100644 --- a/packages/react-table/src/docs/demos/Table.md +++ b/packages/react-table/src/docs/demos/Table.md @@ -233,11 +233,12 @@ class BulkSelectTableDemo extends React.Component { onClick={() => { anySelected ? this.handleSelectClick('none') : this.handleSelectClick('all'); }} - > + > + {numSelected !== 0 && `${numSelected} selected`} + ]} onToggle={this.onDropDownToggle} > - {numSelected !== 0 && {numSelected} selected} } isOpen={isDropDownOpen}