Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - [V6 Empty state] - We should not export the EmptyStateHeader and EmptyStateIcon #10130

Open
tlabaj opened this issue Mar 5, 2024 · 1 comment · May be fixed by #10364
Open

Bug - [V6 Empty state] - We should not export the EmptyStateHeader and EmptyStateIcon #10130

tlabaj opened this issue Mar 5, 2024 · 1 comment · May be fixed by #10364
Assignees
@thatblindgeye
Labels
bug PF6 require codemod
Milestone
Penta beta release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Mar 5, 2024

Describe the problem
A clear and concise description of the problem. Which components are affected?

The componet is building the Header internally with the required titleText prop, so we no longer need to export EmptyStateHeader. To add an icon to the header, you would pass the icon prop directly to the EmptyState component.
@tlabaj tlabaj added this to the Penta beta release milestone Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This was referenced May 14, 2024
Closed
Open
@thatblindgeye thatblindgeye linked a pull request May 14, 2024 that will close this issue
fix(EmptyState): Removed export of Header and Icon subcomponents #10364
Open
@thatblindgeye thatblindgeye mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
bug PF6 require codemod
Projects
PatternFly Issues
Status: PR Review
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix(EmptyState): Removed export of Header and Icon subcomponents thatblindgeye/patternfly-react
3 participants
@tlabaj @kmcfaul @thatblindgeye