Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schedule support for typed API field #284

Merged
merged 4 commits into from
Oct 23, 2022
Merged

Update schedule support for typed API field #284

merged 4 commits into from
Oct 23, 2022

Conversation

paultyng
Copy link
Owner

@paultyng paultyng commented Oct 23, 2022 •
edited

Investigating #263

@paultyng paultyng changed the title Test removing schedule Update schedule support for typed API field Oct 23, 2022
@paultyng paultyng mentioned this pull request Oct 23, 2022
Open
@paultyng paultyng linked an issue Oct 23, 2022 that may be closed by this pull request
Disable defunct WLAN schedule not found #263
Open
@paultyng paultyng marked this pull request as ready for review October 23, 2022 12:58
@paultyng
Copy link
Owner Author

This will break for anyone currently using schedule in the unifi_wlan resource, but I'm not sure it's working properly anyway, and that old API field is a lot harder to work with so while I don't love breaking changes, I think this will be better for folks in the long run.

@paultyng paultyng merged commit d61a34d into main Oct 23, 2022
@paultyng paultyng deleted the wlan-schedule branch October 23, 2022 13:00
joshuaspence pushed a commit to chrishas35/terraform-provider-unifi that referenced this pull request Mar 1, 2023
@paultyng @joshuaspence
Update schedule support for typed API field (paultyng#284)
1748012 
* Test removing schedule

* Use new schedule API field

* fix attribute name

* Bump go-unifi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable defunct WLAN schedule not found
1 participant
@paultyng