feat: Allow specifying heading_level as a Markdown heading instead #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also refactors the regex to use the MULTILINE flag instead of the complex "manual" alternative for detecting newlines.
|
Hehehe, you're quick 😉 Sorry for not merging in order 😅 |
|
There would've been a conflict regardless. I was ready :) |
|
Hold on, I might have detected a buggy interaction with the passed config dict (now ChainMap but doesn't change the situation) here. This is mutating it, which may affect other things. |
This actually happened to not cause any problems even with the mutation, but better to be safe.
|
It is done.
|
|
Great, thanks, squashing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors the regex to use the
MULTILINEflag instead of the complex "manual" alternative for detecting newlines.