Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend documentation with all available adapters #228

Open
RaphaelManke opened this issue Aug 9, 2022 · 1 comment
Open

Extend documentation with all available adapters #228

RaphaelManke opened this issue Aug 9, 2022 · 1 comment

Comments

@RaphaelManke
Copy link

Hi
we have a simple react app that does't use react router.
In Version 2 one has to specify the adapter that should be used. We tried to use one of the react routers but this failed because react router is not installed.

By checking the code implementation we found a window-adapter which worked.
This adapter is never mentioned in the docs.
Is it safe to use this adapter?
Should the docs be extended by mentioning all possible adapters that can be use.

@pbeshai
Copy link
Owner

pbeshai commented Aug 31, 2022

Should be fine to use those adapters, they're just lower priority for maintenance than the React Router ones. But they're pretty simple and shouldn't be too bad to adjust if you run into issues. PRs welcome to update the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants