Throw error when there is no zero value in enum #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometkim
reviewed
Apr 9, 2022
| return false | ||
| } | ||
| }, false) === false) { | ||
| throw new Error("enum must have field for 0."); |
There was a problem hiding this comment.
according to the official docs,
enum definition must contain a constant that maps to zero as its first element. might be clearer.
|
I close this PR because it needs to work like this only in proto3, so I think I need to implement it again. |
cometkim
reviewed
Apr 9, 2022
Comment on lines
+868
to
+875
| if (statements.reduce((acc, statement) => { | ||
| switch (statement.type) { | ||
| case "enum-field": | ||
| return statement.fieldNumber.value.text === "0" || acc; | ||
| default: | ||
| return false | ||
| } | ||
| }, false) === false) { |
There was a problem hiding this comment.
I think statements.filter(statement => statement === "enum-field").find(statement => statement.fieldNumber.value.text === "0") == null is better here.
Searching for field values for a single enum body is trivial, even if it's tens of thousands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make parser throw if there is no zero value in enum
PS. Please recommend something appropriate for error.
Closes #194