Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle dependencies using single file #251

Open
BeLeap opened this issue Oct 19, 2022 · 3 comments
Open

handle dependencies using single file #251

BeLeap opened this issue Oct 19, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@BeLeap
Copy link
Member

BeLeap commented Oct 19, 2022

Dependencies are splitted across multiple files, making it difficult to manage. I think it would be better to declare dependencies in single file.

ref. https://github.com/denoland/deno_blog/blob/main/deps.ts

@BeLeap BeLeap changed the title handle dependencies using singe file handle dependencies using single file Oct 19, 2022
@BeLeap
Copy link
Member Author

BeLeap commented Oct 19, 2022

Additionally, we can use deno cache deps.ts to retrieve dependencies at once.

@BeLeap BeLeap added the good first issue Good for newcomers label Oct 19, 2022
@disjukr
Copy link
Member

disjukr commented Oct 20, 2022

As a library project(think the files in core, codegen, compat), I don't think it is fit method to manage deps.
This approach(deps.ts) bothers fetching minimum files when an application use a part of pbkit.
Also, we can use deno cache **/*.ts to cache dependencies at once.

But I'm okay with using this method only in an application project something like CLI.

@BeLeap
Copy link
Member Author

BeLeap commented Oct 20, 2022

I strongly agree with you. Applying it to cli looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants