-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGR Options & TypeScript #5
Comments
Sure. PR's welcome! |
BTW, plugins like Perhaps we can make it built-in and decide when to use it by https://vitejs.dev/config/#conditional-config |
Fixed in v0.6.0. Thanks for @IanVS 's work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@pd4d10 Thanks for creating the plugin. Works nicely and I like that I can use both the default export for the src/path of the svg and the named export for the React component.
I was wondering if you would accept a PR to enable the plugin users to pass SVGR options (e.g.
{ plugins: ['@svgr/plugin-svgo'] }
).Also, I think the plugin should provide the typings to support this change to svg file imports. A simple
client.d.ts
with the typings suggested in #3 which is then added by the users to thetsconfig.json
like"types": ["vite/client", "vite-plugin-svgr/client"]
would be a solution.The text was updated successfully, but these errors were encountered: