Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XML to match convention #52

Open
altavir opened this issue Feb 10, 2021 · 2 comments
Open

Update XML to match convention #52

altavir opened this issue Feb 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@altavir
Copy link
Contributor

altavir commented Feb 10, 2021

stringify -> encodeToString
toXML -> encodeToXml
parse -> decodeFromXml

Right now you have both, but it is a bit confusing. I think it won't hurt to use canonical names.

@pdvrieze
Copy link
Owner

These are on the list. I figured I'd keep the old ones around a while to allow people more time to move. I can make the deprecations errors though.

@pdvrieze pdvrieze added the enhancement New feature or request label Feb 15, 2021
@pdvrieze
Copy link
Owner

I've reviewed these functions. All of them should be properly deprecated. At the same time I have moved the error level to ERROR for some that are quite old now. I will keep a lookout for the warning level deprecations and move them to error next major release (and remove them after that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants