Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPMS compatibility #7

Open
altavir opened this issue May 29, 2019 · 6 comments
Open

JPMS compatibility #7

altavir opened this issue May 29, 2019 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@altavir
Copy link
Contributor

altavir commented May 29, 2019

Currently I can't use the serialization plugin in jlink due to split package problem. It could be fixed by package renaming.

@pdvrieze
Copy link
Owner

pdvrieze commented Jun 7, 2019

I haven't really tried looking at jdk versions after 8 (including java 9 modules). I'll have a look at trying to reorganize the packages to remove package name sharing.

@pdvrieze
Copy link
Owner

One of the issues is that there is not really a good path to (jigsaw) modular with multiplatform Kotlin. I may come up with a hack that will do so anyway, but it will be tricky (also due to output directories etc). I've added module name attributes in the manifest though (that's easy) and attempted to make all packages unique.

@pdvrieze pdvrieze added enhancement New feature or request help wanted Extra attention is needed labels Jun 10, 2019
@altavir
Copy link
Contributor Author

altavir commented Jun 10, 2019

There are jpms-compatible stdlib artifacts. They go with modular qualifier. Also there is this thread.

As far, as I understand, you do not need to add a module manifest to make project work with jpms. You can use default module. The only thing you need to fix is to remove same package names in separate modules.

@pdvrieze
Copy link
Owner

The current head should not have any issues with modular package names anymore. I will wait until kotlin 1.3.40 to make a proper modular version as that version has withJava support that I can use to compile module-info.javafiles.

@pdvrieze
Copy link
Owner

pdvrieze commented Jul 2, 2019

This should be resolved with the 0.11.1.1 release. In addition there is the jigsaw branch that should be properly modular, but may create all kinds of issues due to having multiple jvm artifacts (one targeting jdk8, another targeting jdk9)

@pdvrieze
Copy link
Owner

@altavir I've added hopefully proper support in the moduleInfo branch. It would be good if you could check that it is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants