Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR handling (vite) #10

Open
walmartwarlord opened this issue Jan 11, 2023 · 1 comment
Open

HMR handling (vite) #10

walmartwarlord opened this issue Jan 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@walmartwarlord
Copy link

Yo Im using this package for an experiment, it works great. Wondering if there's anything we can do for it to handle HMR?

For example, using this to open dialogs/modals... changing the theme of the main app instance doesnt change the mounted component using this module since it only attaches appContext under the hood.

any help would be much appreciated!

@pearofducks
Copy link
Owner

I'm not aware of a way to hook this plugin into Vue's HMR updates - I'm fairly certain those are treated as internals anyhow, so would be subject to breaking changes without notice from Vue.

This plugin is mostly intended for singletons like Toast - it shouldn't be necessary to use with dialogs or modals since those can easily be made into components that live inside the app.

@pearofducks pearofducks added the enhancement New feature or request label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants