-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeException when stopStream #1460
Comments
Hello, |
I pulled the latest code from the master branch. I tried to remove the throw RuntimeException in GLUtil, This GL error does not appear fatal public static void checkGlError(String op) {
int error = GLES20.glGetError();
if (error != GLES20.GL_NO_ERROR) {
throw new RuntimeException(op + ". GL error: " + error);
}
} |
Hello, Ideally it should be solved instead of ignored.
Log.e("Pedro", "id: ${Thread.currentThread().id}, name: ${Thread.currentThread().name}")
public static void checkGlError(String op) {
int error = GLES20.glGetError();
if (error != GLES20.GL_NO_ERROR && error != GLES20.GL_OUT_OF_MEMORY) {
throw new RuntimeException(op + ". GL error: " + error);
}
} This way you only exclude this error instead of all gl errors Please, test it all and let me know the result. I will try to add a proper fix depend of your tests. |
Hello,
|
Hello, Thank you for the logs. I suppose that you are using Rotation example. If not, let me know the example used. I did the fix for Rotation example and I will add it to all if it is working fine. |
hello, Thank you for your reply. Rotation is worked. Just setCameraOrientation(0) not very friendly, maybe use VideoSource rotation control the stream rotation? #1462
|
Hello,
Nice, I will remove logs and add the fix.
Which one? This?: It is totally necessary to use always 0. You can't do it inside VideoSource because you haven't access to glInterface inside a VideoSource. I'm not sure if add a setter or similar because I don't want make VideoSource depend of glInterface to allow use it without glInterface. Other option could be check if you are using a ScreenSource and set that value to 0 before call create method but add a conditional only for a VideoSource feels like a bad idea. What do you think about it? do you have a better idea? which option do you like (current, glInterface setter or internal ScreenSource conditional)? |
Hello:
The demo run on a rk3399 chip device (Android 7.1.2) throw RuntimeException when stopStream sometimes.
here is the error logs
The text was updated successfully, but these errors were encountered: