Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate camera files for rebel line #19

Open
powturns opened this issue Mar 10, 2019 · 1 comment
Open

Duplicate camera files for rebel line #19

powturns opened this issue Mar 10, 2019 · 1 comment

Comments

@powturns
Copy link
Contributor

powturns commented Mar 10, 2019

The rebel line of canon cameras (T*i) have duplicate camera definition files - one for the official model and another for the localized model name.

I don't think the localized model name file is necessary as the camera is populated from the alias section of the official model file.

Eg: a T2i camera has its properties defined in T2i.toml and 550d.toml

@pedrocr
Copy link
Owner

pedrocr commented Mar 10, 2019

Yep seems like that's the case. Probably a leftover from before I implemented aliases. I doubt it happens in many cases. Probably a good thing to fix after I implement the regression testing setup I've thought about. That way I can do the changes and check that the output is still all the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants