Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official and localized models #20

Open
powturns opened this issue Mar 10, 2019 · 1 comment · May be fixed by #21
Open

Official and localized models #20

powturns opened this issue Mar 10, 2019 · 1 comment · May be fixed by #21

Comments

@powturns
Copy link
Contributor

When an image file contains an alias of the camera model, rather than the official camera model, there is no way to relate back to the official model.

For example, with a T3i, I would expect to get back the official model of Canon EOS 600D (from data/cameras/canon/600d.toml) when calling camera.model. However, instead I get back the localized model Canon EOS REBEL T3i.

This can introduce difficulties when you want to branch behaviour based on the camera model as each localized case must be handled, rather than a single official model case.

Proposal would be to modify RawImage.{model, clean_model} to return the official model name, and add two new properties RawImage.{localized_model, clean_localized_model} that return the localized model name.

@pedrocr
Copy link
Owner

pedrocr commented Mar 10, 2019

I'd take a PR but to do the opposite. Keep what's already there the same and add a canonical_make and canonical_model. I think that's how I did it in rawspeed for the same reasons. For all user-visible purposes you want the actual name of the camera, that's what the user knows it by. It's only for software purposes that you want a single canonical name as you don't care about Canon's (and a few others) crazy marketing setups.

@powturns powturns linked a pull request Mar 10, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants