Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added canonical_model to image and camera #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

powturns
Copy link
Contributor

@powturns powturns commented Mar 10, 2019

Fixes #20 but doesn't do anything until #19 is fixed as the rebel definitions simply overwrite the canonical_model values

@powturns powturns changed the title Added canonical_model to image and camera to allow software to get Added canonical_model to image and camera Mar 10, 2019
@pedrocr
Copy link
Owner

pedrocr commented Mar 10, 2019

There's no point in having clean_canonical_model, the canonical names will always be clean. It's almost surely not the case this doesn't do anything as most cameras don't have the issue in #19. But feel free to remove the camera you personally have as you can test it. It's to do the mass delete that I want to have the regression testing in place.

@powturns
Copy link
Contributor Author

Re: clean_canonical_model:

In the case of a Canon EOS DIGITAL REBEL T3i, if there isn't a clean canonical model, should the canonical_model be Canon EOS 600D or EOS 600D?

Currently in this PR:
canonical_model = Canon EOS 600D
clean_canonical_model = EOS 600D

@pedrocr
Copy link
Owner

pedrocr commented Mar 11, 2019

Do you need both for some reason? I'd use clean_model of the parent camera as canonical_model of itself and all aliases. If the point is to have one way to index into a specific camera having two versions of a "canonical" name sounds very strange. And using the clean one is best as cameras often have wonky names and the clean ones unify a lot of stuff so they're nicer if you want to automatically match something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official and localized models
2 participants