Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wrap" option misleading #42

Open
apepper opened this issue Sep 17, 2020 · 0 comments
Open

"wrap" option misleading #42

apepper opened this issue Sep 17, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@apepper
Copy link

apepper commented Sep 17, 2020

https://peterpalau.github.io/react-bnb-gallery/#/options currently states the following:

Name Type Default Description
wrap boolean false Whether the gallery should cycle continuously or have hard stops.

My understanding would be, that wrap=false would not show a previous-button on the first image. I would further expect, that wrap=true would show a previous-button on the first image.

Currently the opposite is true: With wrap=true no previous-button is shown on the first image.

I would either change the description or change the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants