Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 support #45

Open
apepper opened this issue Oct 29, 2020 · 5 comments
Open

React 17 support #45

apepper opened this issue Oct 29, 2020 · 5 comments
Labels

Comments

@apepper
Copy link

apepper commented Oct 29, 2020

Currently react-bnb-gallery supports react 15 and 16:

https://github.com/peterpalau/react-bnb-gallery/blob/ad411497c42c1bbdf8c16c7e4ab5a35844a9529a/package.json#L58-L61

It would be great, if it would also support the latest React 17 release.

@apepper
Copy link
Author

apepper commented Oct 29, 2020

Please note that the sub-dependency focus-trap-react currently does not support react 17 yet:

https://github.com/peterpalau/react-bnb-gallery/blob/ad411497c42c1bbdf8c16c7e4ab5a35844a9529a/package.json#L130

At least not a released version. My guess is, that version 8.2.0 will have a fix, once it is released (see merged but not yet released PR).

@apepper
Copy link
Author

apepper commented Mar 10, 2021

focus-trap-react is now compatible with react 17 starting with version 8.1.1 or newer (see https://github.com/focus-trap/focus-trap-react/releases/tag/v8.1.1).

@joeyfigaro
Copy link

@peterpalau any movement here?

@joeyfigaro
Copy link

Opened a simple PR for this – #90

@joeyfigaro
Copy link

joeyfigaro commented Oct 6, 2021

...looks like the airbnb proptypes package does not currently support React 17. This is probably held up until they fix that–or the dependency is dropped/removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants