-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix window.Store.ProfilePic.profilePicFind is not a function error #3001
Fix window.Store.ProfilePic.profilePicFind is not a function error #3001
Conversation
…Pic.requestProfilePicFromServer
and how about previous wa-versions? |
In 2.2412.54, |
We need to make an implementation that is supported on both versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support for previous WWeb versions,
you can use window.WWebJS.compareWwebVersions
that is located in
src/util/Injected/Utils.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it will break for older versions. I believe the best solution would be something like:
return await (window.Store.ProfilePic.profilePicFind || window.Store.ProfilePic.requestProfilePicFromServer)(chatWid);
Don`t work |
Hey, whatsapp-web.js/docs/Client.js.html Line 1227 in 41b280c
|
PR Details
Replace
window.Store.ProfilePic.profilePicFind
withwindow.Store.ProfilePic.requestProfilePicFromServer
Description
The function
window.Store.ProfilePic.profilePicFind
is no longer available in v2.3x, and is replaced with
window.Store.ProfilePic.requestProfilePicFromServer
Related Issue
closes #3005
Motivation and Context
How Has This Been Tested
Types of changes
Checklist