Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompilation step for cra apps #37

Merged
merged 1 commit into from Jun 13, 2018
Merged

Conversation

Shahor
Copy link
Contributor

@Shahor Shahor commented Jun 12, 2018

No description provided.

@Maher4Ever
Copy link

Would to see this merged and released as soon as possible!

@jhnns jhnns merged commit d2d3728 into peerigon:master Jun 13, 2018
@jhnns
Copy link
Member

jhnns commented Jun 13, 2018

Awesome 👍. Shipped with v2.1.2

@Maher4Ever
Copy link

Unfortunately, issue #26 still happens with v2.1.2 😞

@jhnns
Copy link
Member

jhnns commented Jun 18, 2018

That's probably because there is no precompilation step 😁. I asked if cra picks up the .babelrc but received no answer. Since I'm not using cra and I don't know about the internals, I assumed that this change would fix it.

@Maher4Ever
Copy link

@jhnns CRA expects used modules to be pre-compiled. Adding a pre-compilation step before publishing parse-domain wouldn't be that difficult right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants