Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not parse police.uk domain correctly #64

Closed
jpstevens opened this issue Feb 19, 2019 · 0 comments
Closed

Does not parse police.uk domain correctly #64

jpstevens opened this issue Feb 19, 2019 · 0 comments

Comments

@jpstevens
Copy link
Contributor

The domain police.uk is listed on the pubic suffix list:
https://publicsuffix.org/list/public_suffix_list.dat

However when I run parseDomain("www.police.uk") the TLD returned is uk - it should be police.uk.

I've reviewed the code and the issue relates to some logic around how tries are created when line and prevLine are different lengths. PR to follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpstevens