Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null if urlSplit is null - fix issues 32 and 61 #70

Merged
merged 1 commit into from May 28, 2019

Conversation

dydeepak97
Copy link
Contributor

No description provided.

@jhnns
Copy link
Member

jhnns commented May 27, 2019

Thank you for your PR and for adding tests ❤️. This has already been addressed with #63

@jhnns jhnns closed this May 27, 2019
@dydeepak97
Copy link
Contributor Author

dydeepak97 commented May 27, 2019

@jhnns The changes in #63 will not cover the case of these character being present with other valid charcter. e.g., https://www.hell\no.com. \n charater present in url will cause the same error.

@jhnns
Copy link
Member

jhnns commented May 28, 2019

You're right, sorry. It was too late yesterday :)

@jhnns jhnns reopened this May 28, 2019
@jhnns jhnns merged commit 28d7e4b into peerigon:master May 28, 2019
jhnns added a commit that referenced this pull request May 28, 2019
@jhnns
Copy link
Member

jhnns commented May 28, 2019

Published with v2.2.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants